This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Move SRV magic into an Agent-like thing #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/matrix_federation_agent
branch
from
582a504 to
8f23d87
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4428 +/- ##
===========================================
- Coverage 73.7% 73.66% -0.05%
===========================================
Files 300 302 +2
Lines 29705 29816 +111
Branches 4882 4895 +13
===========================================
+ Hits 21895 21963 +68
- Misses 6385 6426 +41
- Partials 1425 1427 +2 |
Pull the magic that is currently in matrix_federation_endpoint and friends into an agent-like thing
... instead of the matrix_federation_endpoint
this thing is now redundant.
richvdh
force-pushed
the
rav/matrix_federation_agent
branch
from
8f23d87 to
c66f4bf
Compare
it is only ever a bytes now, so let's enforce that.
this makes it easier to stub things out for tests.
|
sorry about the size of this PR. You might find the individual commits easier to review. |
|
https://codecov.io/gh/matrix-org/synapse/pull/4428/diff#D5-104 isn't hit via coverage, which means |
hawkowl
approved these changes
Jan 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR builds on top of #4426 and #4427)This PR replaces the matrix_federation_endpoint with a thing that is implemented in an Agent instead. This simplifies a bunch of code, and is a prerequisite for .well-known support.